Communication boiler #2114
Merged
Communication boiler #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delete manipulator control node * delete node * delete maniuplators vector * Fix Code Style On delete_maninpulator_node (#2084) automated style fixes Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com> * Remove mention to removed filed * Fix Code Style On delete_maninpulator_node (#2090) automated style fixes Co-authored-by: Ninjatest321 <Ninjatest321@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com> Co-authored-by: Robojackets <amoghj303@gmail.com> Co-authored-by: Ninjatest321 <Ninjatest321@users.noreply.github.com>
|
i keep forgetting to test this myself. if someone can just demo it working (or if @Ninjatest321 approves it) you're good to merge |
|
actually i would also like @N8BWert to review when he has time |
|
Also manually confirmed style here. Need to fix that check |
sid-parikh
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We created a communication generation script (
communication_gen.py) that dynamically generates relevant communication files based on ROS messages. Whenever a new ROS message is created inrj_msgs/msg/requestorrj_msgs/msg/response, runcd soccer/src/soccer/strategy/agent/communication && python3 communication_gen.pyfrom the main directory. This will automatically updatecommunication.hpp,communication.cpp, and create the corresponding hpp file for the message. The comments associated with the original structs of the ROS messages have been moved to their.msgfiles.Associated / Resolved Issue
ClickUp card
Steps to Test
.msgfile torj_msgs/msg/requestorrj_msgs/msg/responsecd soccer/src/soccer/strategy/agent/communication && python3 communication_gen.pymake perfExpected result:
Nothing breaks and simulator runs as expected
Key Files to Review
Contents of
soccer/src/soccer/strategy/agent/communicationReview Checklist