Eduardo rodriguez/robocup sw tutorial #2102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automated style fixes Co-authored-by: Nekronos-SPN <Nekronos-SPN@users.noreply.github.com>
automated style fixes Co-authored-by: Nekronos-SPN <Nekronos-SPN@users.noreply.github.com>
sid-parikh
reviewed
Oct 5, 2023
|
|
||
| switch (current_state_) { | ||
| case RIGHT: | ||
| if (robot_position.x() <= field_dimensions_.field_x_left_coord() + 1.1) next_state = UP; |
There was a problem hiding this comment.
note the GH actions warnings here. inline if statements are hard to read! it's fine for now, but won't be approved in the future
sid-parikh
approved these changes
Oct 5, 2023
|
Great work overall! Congratulations! |
sid-parikh
approved these changes
Oct 5, 2023
| /* | ||
| * This robot runs in a square path | ||
| */ | ||
| class Runner : public Position { |
There was a problem hiding this comment.
note the GH actions here and perhaps read up on the rule of 5. you can set many of those to the default implementation, but it's best to explicitly do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software tutorial completion
Double space between wallers
This was accomplished on the first commit of the pull request.
File path for topic message type
The topic the tutorial asks for does not exist anymore. I will just provide the path to all the message types used by the topics listed.
./rj_msgs/msg/*
Recording of rqt usage
rqt_tutorial-2023-09-17_19.54.23.mp4
Soccer mom node
Code of working soccer mom node on the second commit of the pull request.
https://github.com/RoboJackets/robocup-software/assets/77493047/4ff2a7eb-ecaa-401e-8558-7a8e9d01365a
Runner position
Code of runner position on the third commit of the pull request.