Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: Supporting Express 5 #1530

Merged
merged 78 commits into from
Sep 10, 2024
Merged

Epic: Supporting Express 5 #1530

merged 78 commits into from
Sep 10, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Jan 30, 2024 •
edited
Loading

Instead of #374 but non-breaking

The express 5 beta 3 is fully operational and tested by community, but its release is delayed.
The current issue is that it's also outdated comparing to v4.18.2, having nested dependencies of older versions.

latest tracking issue:

https://github.com/expressjs/discussions/issues/233

previous one:

https://github.com/expressjs/express/issues/5205

Latest proposal:

https://github.com/expressjs/discussions/issues/160

Probably it will be ready in march 🤞🏽 (no, it's not)

https://github.com/expressjs/express/discussions/5111#discussioncomment-4811950

@RobinTail RobinTail added the enhancement New feature or request label Jan 30, 2024
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 30, 2024 •
edited by coveralls-official bot
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 3a59641 on express5-2024
into b459c50 on master.

RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 30, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@RobinTail RobinTail mentioned this pull request Feb 19, 2024
Merged
@RobinTail RobinTail modified the milestone: v17 Feb 19, 2024
@RobinTail RobinTail added the dependencies Pull requests that update a dependency file label Feb 29, 2024
@RobinTail
Copy link
Owner Author

I can't believe it!

@RobinTail RobinTail changed the title Future: supporting Express 5 Epic: Supporting Express 5 Sep 10, 2024
@RobinTail RobinTail marked this pull request as ready for review September 10, 2024 07:58
@RobinTail
Copy link
Owner Author

RobinTail commented Sep 10, 2024 •
edited
Loading

I need to figure out how @types/express should be addressed, because there is no update there yet.
Latest enquiry on that matter is here: expressjs/express#2237 (comment)

@RobinTail
Copy link
Owner Author

These are expected changes in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69846/files#diff-5962769e8693df44c9e1083881fb1da149a67262026db939b7430536d514e7af

Screenshot 2024-09-10 at 14 06 44

@RobinTail RobinTail added miracle Mysterious events are happening here patched Some dependency is patched labels Sep 10, 2024
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Sep 10, 2024
RobinTail
RobinTail commented Sep 10, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail merged commit c5a45b1 into master Sep 10, 2024
12 checks passed
@RobinTail RobinTail deleted the express5-2024 branch September 10, 2024 14:56
@RobinTail RobinTail mentioned this pull request Sep 25, 2024
Merged
RobinTail added a commit that referenced this pull request Sep 25, 2024
@RobinTail
Enabling @types/express v5 (#2059)
3d75e92 
Using types/express 5 internally, allowing that version as peer and
removing temporary patch.

Reverts the temporary patch made in #1530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request miracle Mysterious events are happening here patched Some dependency is patched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @coveralls