Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable warnings-as-errors in mix test #153

Merged

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jul 2, 2024

This supposes to catch those deprecation warnings in Elixir 1.15,16,17 and Erlang/OTP 25,26,27.

Follow-up discussion in #152 (comment)

This supposes to catch those deprecation warnings in Elixir 1.15,16,17
and Erlang/OTP 25,26,27.
@RobertDober RobertDober merged commit b93955f into RobertDober:master Jul 2, 2024
5 checks passed
@RobertDober
Copy link
Owner

RobertDober commented Jul 2, 2024

I'll have merged this anyway because I see your idea (I guess), suspecting that the compiler itself might be more linient with warnings in tests.

Stupid me, now I get it, .exs files are not compiled in the mix compilestep. 👏

Thanx and take care

@RobertDober
Copy link
Owner

@kianmeng fyi a little bit more was necessary to get the compilation and test step run for the older versions again

Here is what was missing 5228fce

But thanx for putting me on track

@kianmeng
Copy link
Contributor Author

kianmeng commented Jul 3, 2024

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants