-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented custom scrollToHandler. #37
Conversation
@craigsketchley I think you should be able to check |
@craigsketchley want me to give testing a go? |
Hey, yeah, happy for you to have a go. I think I'm close but I'm having trouble finding a way to set the viewport size for testing. Checking if the window has scrolled to the current step element requires that some of the page is out of view. Currently when running the tests the window height and document height are the same so no scrolling occurs :( |
Just pushed where I'm at so you can see my thought process. |
I did see that you can specify the viewport size in PhantomJS. Any idea if we can use that? |
@craigsketchley There is currently a bug that makes Phantom not work. I'll see if I can get it working with Chrome this weekend. |
@craigsketchley I think the problem here is |
Yeah nice work. That makes sense. Your commit looks good to me. |
Implemented custom scrollToHandler.
@craigsketchley got it all merged in, published version 2.0.5. Is there anything we need to document in README.md? |
@rwwagner90 I don't think we need to document anything. Just a fix. |
Haven't got a test for this. Had a bit of trouble testing the scroll position. Any thoughts on the best way to do this?