Stop disabling target element pointer events

[BrianSipple]

I got started on a branch in shepherd that will allow for a disableAttachTarget step option.

In the meantime, though, we can get started with the corresponding change here.

[BrianSipple]

Side note: Whenever modal mode is active, target elements won't be clickable anyway. So I think it works out quite nicely that we can have that broad experience here, while still enabling fine-grained step control at the shepherd level.

[RobbieTheWagner]

Remember we were not going to just remove this stuff, but allow a clickable: false to be passed to enable it?

[BrianSipple]

Okay, I was experimenting with the shepherd approach and figured that since clickable would be true by default, this would be good start.

I can refactor this, though, after some of our discussion about keeping things in ember-shepherd

[BrianSipple]

@rwwagner90 @chuckcarpenter Thinking about how to document this... this might be a good opportunity to clean up the README and only document the extra step options (while linking to docs for Shepherd's step options.

Also, what you think about isClickable (as opposed to clickable)?

[BrianSipple]

I still kind of like disableAttachTarget, too. clickable might be confusing, because I can imagine a lot of people thinking it refers to the step element itself.

[RobbieTheWagner]

this might be a good opportunity to clean up the README and only document the extra step options

Let's keep all the docs for now.

I still kind of like disableAttachTarget, too. clickable might be confusing, because I can imagine a lot of people thinking it refers to the step element itself.

I'd like a simpler name. clickable I think makes sense to the masses. disableAttachTarget isn't clear to me what it does. I'm open to other names, but I want it to be something the common person can understand. Perhaps attachToElementClickable, interactiveAttachTo, etc? I'm not sure of a good name myself. It's going to have to be documented regardless, so the name isn't super important.

[BrianSipple]

canClickTarget?

[RobbieTheWagner]

I think I'm okay with canClickTarget. Let's just get something in there, and see if it feels right 😄

[BrianSipple]

@rwwagner90 Just updated and rebased around implementing a canClickTarget step option.

[RobbieTheWagner]

We've got some code climate issues, but we can fix those later. Thanks!