Update add-on to use Shepherd with Popper.js #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckcarpenter
commented
Jun 29, 2018
| @@ -134,7 +134,7 @@ module('Acceptance | Tour functionality tests', function(hooks) { | |||
| await click('.toggleHelpModal'); | |||
|
|
|||
| assert.ok(document.body.classList.contains('shepherd-active'), 'Body gets class of shepherd-active, when shepherd becomes active'); | |||
| assert.equal(document.querySelectorAll('.shepherd-enabled').length, 2, 'attachTo element and tour have shepherd-enabled class'); | |||
| assert.equal(document.querySelectorAll('.shepherd-enabled').length, 1, 'attachTo element has the shepherd-enabled class'); | |||
There was a problem hiding this comment.
you can use the shepherd-open class
RobbieTheWagner
force-pushed
the
feature/migrate-popper
branch
from
6478ed8
to
f072ce4
Compare
Update yarn.lock Co-authored-by: Robert Wagner <rwwagner90@gmail.com> Co-authored-by: Chuck Carpenter <chuck.carpenter@me.com>
RobbieTheWagner
force-pushed
the
feature/migrate-popper
branch
from
76c8ea3
to
d190970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.