Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overloads for const std::string& and const char* arguments #258

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Added overloads for const std::string& and const char* arguments #258

merged 1 commit into from
Oct 9, 2023

Conversation

Bigfoot71
Copy link
Contributor

This is primarily a suggestion, wouldn't adding an overload function LoadFromMemory(const char* vsCode, const char* fsCode) be more convenient in the case where we might, for example, want to load a fragment shader from memory with the default vertex shader?

For the sake of consistency, I've also added one for static ::Shader Load(...), to see if it would be equally useful.

@RobLoach
Copy link
Owner

RobLoach commented Oct 9, 2023

Thanks a lot 👍 ... Could apply to the other ones classes too, but not absolutely needed.

@RobLoach RobLoach merged commit a3c520a into RobLoach:master Oct 9, 2023
@Bigfoot71
Copy link
Contributor Author

I checked just in case, but I don't see any other raylib functions that would have a specific behavior when a null pointer is given rather than a "string".

The proposed modification was primarily for this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants