Add support for the extensions in the Microsoft Edge Addons Store #101
Conversation
|
@Rob--W Made the changes suggested by you. Please review. |
There was a problem hiding this comment.
Nice. The patch is quite good, I checked the rest of the code and you didn't forget anything else, except for one obscure one: you should also add a mea_pattern check at
Line 1577 in e150056
Added this change. The new patchset is ready for review. |
src/cws_pattern.js
Outdated
| // Chrome Web Store | ||
| match = get_extensionID(extensionID_or_url); | ||
| var extensionID = match ? match : extensionID_or_url; | ||
|
|
||
| if (!/^[a-z]{32}$/.test(extensionID)) { | ||
| return extensionID_or_url; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Please remove this space change, squash all commits together with a meaningful description and I'll merge it.
utkarshspat
changed the title
|
@Rob--W Done everything that you suggested. Please review it once and merge the changes. |
|
@Rob--W |
|
The patch author mailed me that the feature isn't working as intended for them. I asked for reproduction steps but have yet to hear back. Usually they responded very quickly, so I guess that they're on a break. |
|
Fixed by the recent commits, perhaps? |
|
@AirQuick Yes it has been fixed by the recent changes at 9ba5189...3b2f3a1 I need to publish an update. It has been a while since I've done that so I need to spend some time to look into the changes from the Chrome Web Store, and investigate whether I need to consider uploading to the Microsoft Addons gallery. |
Created the patch to add support for the extensions in the Microsoft Edge Addons Store: https://microsoftedge.microsoft.com/addons/Microsoft-Edge-Extensions-Home
Tested that with this change, the sources of extensions from both Chrome Webstore as well as Microsoft Edge Addons Store can be seen/downloaded and the corresponding CRX packages can also be downloaded.