Better exception message for when default value is an enum #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Nov 24, 2023
| ])); | ||
| $classInfo = $reflector->reflectClass('Bat'); | ||
|
|
||
| $this->expectException(UnableToCompileNode::class); |
There was a problem hiding this comment.
We should check at least part of the exception message in this test: it seems like the mutation test reports no behavioral change (removes throw and is happy with that), which indicates that an assertion is to be added here
|
Sorry for a delay, I was working remotely for a couple of days. I added a message check. You can look at it. |
Ocramius
requested changes
Dec 4, 2023
|
I think the failures are unrelated to your patch, and instead depend on shivammathur/setup-php#799 |
Ocramius
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
LGTM, thanks @forrest79!
I will re-run tests and merge once the upstream issue with the CI pipeline is resolved, then releasing 💪
Ocramius
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue #1376.