Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto loading stats on launch does not work #92

Closed
UlyssesZh opened this issue Jan 17, 2024 · 3 comments
Closed

Auto loading stats on launch does not work #92

UlyssesZh opened this issue Jan 17, 2024 · 3 comments
Assignees
@RoanH
Labels
bug

Comments

@UlyssesZh
Copy link

UlyssesZh commented Jan 17, 2024 •
edited
Loading

Auto loading stats on launch does not work. I can, however, load stats manually after it launches.

Relevant part of the config file:

statsSaving:
  autoSave: true
  autoDestination: /home/ulysses/data/KeysPerSecond/stats
  autoFormat: 'md.kpsstats'
  autoInterval: 1000
  saveOnExit: true
  loadOnLaunch: true
  saveFile: /home/ulysses/data/KeysPerSecond/stats/md.kpsstats

Tested on Linux with KPS 8.8.
@RoanH
Copy link
Owner

RoanH commented Jan 17, 2024

Seems like there's a few issues here, not entirely sure yet where things go wrong exactly but I'll make sure it works again for the next release (stats saving in general seems to be in bad shape...). Thanks for the report!

@RoanH RoanH self-assigned this Jan 17, 2024
@RoanH RoanH added the bug label Jan 17, 2024
@RoanH
Copy link
Owner

RoanH commented Jan 17, 2024

Alright, it appears that this works when manually loading a config and only fails when the config is being loaded via cli/default. Should not be hard to fix.

@RoanH RoanH mentioned this issue Jan 20, 2024
Merged
RoanH added a commit that referenced this issue Jan 20, 2024
@RoanH
Pass all config load calls through a single function
d0f268c 
fix issue #92 (GitHub)
fix issue roan/KeysPerSecond#271 (GitLab)
RoanH added a commit that referenced this issue Jan 21, 2024
@RoanH
Merge branch 'defaultfix' into 'master'
dade9b4 
Various Config Fixes

Closes #270, #276, and #271
See #92 and #93 (GitHub)

See merge request roan/KeysPerSecond!46
@RoanH
Copy link
Owner

RoanH commented Jan 21, 2024

This should now work properly again and hopefully shouldn't regress as easily anymore.

@RoanH RoanH closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoanH RoanH

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RoanH @UlyssesZh