* Changed LineItem's product_id to string from int

* Added CC PaymentDetails token field
Riskified · Jun 5, 2016 · 1bb2d6d · 1bb2d6d
1 parent efefe5d
commit 1bb2d6d
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/Riskified.SDK.Sample/OrderTransmissionExample.cs b/Riskified.SDK.Sample/OrderTransmissionExample.cs
@@ -234,7 +234,7 @@ private static OrderCheckout GenerateOrderCheckout(string orderNum)
 
             var items = new[]
             {
-                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: 48484,sku: "1272727"),
+                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: "48484",sku: "1272727"),
                 new LineItem(title: "Monster", price: 22.3, quantityPurchased: 3)
             };
 
@@ -342,7 +342,8 @@ private static Order GenerateOrder(int orderNum)
                 cvvResultCode: "n",
                 creditCardBin: "124580", 
                 creditCardCompany: "Visa",
-                creditCardNumber: "XXXX-XXXX-XXXX-4242");
+                creditCardNumber: "XXXX-XXXX-XXXX-4242",
+                creditCardToken: "2233445566778899");
 
             var noChargeAmount = new NoChargeDetails(
                 refundId: "123444",
@@ -370,7 +371,7 @@ private static Order GenerateOrder(int orderNum)
 
             var items = new[]
             {
-                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: 48484,sku: "1272727",deliveredTo: DeliveredToType.StorePickup, delivered_at:new DateTime(2016, 12, 8, 14, 12, 12, DateTimeKind.Local)),
+                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: "48484", sku: "1272727",deliveredTo: DeliveredToType.StorePickup, delivered_at:new DateTime(2016, 12, 8, 14, 12, 12, DateTimeKind.Local)),
                 new LineItem(title: "Monster", price: 22.3, quantityPurchased: 3, seller: new Seller(customer: customer,correspondence: 1, priceNegotiated: true, startingPrice: 120)),
                 // Events Tickets Industry 
                 new LineItem(title: "Concert", 
@@ -502,7 +503,7 @@ private static Order PayPalGenerateOrder(int orderNum)
 
             var items = new[]
             {
-                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: 48484,sku: "1272727"),
+                new LineItem(title: "Bag",price: 55.44,quantityPurchased: 1,productId: "48484", sku: "1272727"),
                 new LineItem(title: "Monster", price: 22.3, quantityPurchased: 3)
             };
 

diff --git a/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs b/Riskified.SDK/Model/OrderElements/CreditCardPaymentDetails.cs
@@ -14,13 +14,19 @@ public class CreditCardPaymentDetails : IPaymentDetails
         /// <param name="creditCardBin">The issuer identiﬁcation number (IIN), formerly known as bank identiﬁcation number (BIN) ] of the customer's credit card. This is made up of the ﬁrst few digits of the credit card number</param>
         /// <param name="creditCardCompany">The name of the company who issued the customer's credit card</param>
         /// <param name="creditCardNumber">The 4 last digits of the customer's credit card number, with most of the leading digits redacted with Xs</param>
-        public CreditCardPaymentDetails(string avsResultCode, string cvvResultCode, string creditCardBin, string creditCardCompany, string creditCardNumber)
+        public CreditCardPaymentDetails(string avsResultCode, 
+                                        string cvvResultCode, 
+                                        string creditCardBin, 
+                                        string creditCardCompany, 
+                                        string creditCardNumber, 
+                                        string creditCardToken = null)
         {
             AvsResultCode = avsResultCode;
             CvvResultCode = cvvResultCode;
             CreditCardBin = creditCardBin;
             CreditCardCompany = creditCardCompany;
             CreditCardNumber = creditCardNumber;
+            CreditCardToken = creditCardToken;
         }
 
         /// <summary>

diff --git a/Riskified.SDK/Model/OrderElements/LineItem.cs b/Riskified.SDK/Model/OrderElements/LineItem.cs
@@ -20,7 +20,7 @@ public LineItem(string title,
                         int quantityPurchased,
 
                         //optional
-                        int? productId = null, 
+                        string productId = null, 
                         string sku = null, 
                         string condition = null,
                         bool? requiresShipping = null, 
@@ -106,9 +106,9 @@ public void Validate(Validations validationType = Validations.Weak)
             InputValidators.ValidatePositiveValue(QuantityPurchased.Value, "Quantity Purchased");
 
             // optional fields validations
-            if(ProductId.HasValue)
+            if(ProductId != null)
             {
-                InputValidators.ValidateZeroOrPositiveValue(ProductId.Value, "Product Id");
+                InputValidators.ValidateValuedString(ProductId, "Product Id");
             }
 
             if(Seller != null)
@@ -133,7 +133,7 @@ public void Validate(Validations validationType = Validations.Weak)
         /// The Product ID number
         /// </summary>
         [JsonProperty(PropertyName = "product_id")]
-        public int? ProductId { get; set; }
+        public string ProductId { get; set; }
 
         /// <summary>
         /// Quantity of the item that was purchased

diff --git a/Riskified.SDK/Properties/AssemblyInfo.cs b/Riskified.SDK/Properties/AssemblyInfo.cs
@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.0.4.9")]
-[assembly: AssemblyFileVersion("2.0.4.9")]
+[assembly: AssemblyVersion("2.0.5.0")]
+[assembly: AssemblyFileVersion("2.0.5.0")]