Skip to content

Commit

Permalink
fix shinyapps.io links
Browse files Browse the repository at this point in the history
  • Loading branch information
DivadNojnarg committed Oct 4, 2024
1 parent 5eda3cd commit 42650f8
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 8 deletions.
1 change: 0 additions & 1 deletion R/preview_mobile.R
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#' library(shiny)
#' library(shinyMobile)
#' preview_mobile(appPath = "~/whatever", device = "galaxyNote8")
#' preview_mobile(url = "https://dgranjon.shinyapps.io/miniUI2DemoMd", device = "ipadMini")
#' }
preview_mobile <- function(appPath = NULL, url = NULL, port = 3838,
device = c(
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ Where `APP_PATH` is the app location. Currently, it only works if the app is **i

- A valid `service-worker.js`.
- A valid web manifest (`manifest-webmanifest`). Don't forget to change the `start_url` property to the path of your app.
For instance, the following app hosted at https://dgranjon.shinyapps.io/rstudio-global-2021-calendar/, has the `/rstudio-global-2021-calendar/` path.
- As a bonus a valid `offline.html` fallback, which is displayed when the app is offline.
- A valid set of icons. There are tools such as [appsco](https://appsco.pe/developer/splash-screens) and [app-manifest](https://app-manifest.firebaseapp.com), to create
those custom icons and splash screens, if you need to.
Expand All @@ -79,7 +78,7 @@ The first step is to deploy your app somewhere. It doesn't matter where (shinyap
Then, you can follow these steps to install your app on your mobile device.

<br>
Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). In this example this is: https://dgranjon.shinyapps.io/miniUI2Demo/. It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI.
Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI.

- Select the share button located in the bottom bar of your iPhone/iPad For Android, you may do something similar. Importantly, Chrome for iOS does not support this feature, that's why we recommend using Safari.
- Click on "Add to Home Screen"
Expand Down
2 changes: 2 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@
## R CMD check results
There were no ERRORs or WARNINGs or NOTEs.

## Re-submission

Update links.
1 change: 0 additions & 1 deletion man/preview_mobile.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions vignettes/pwa.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ Where `APP_PATH` is the app location. Currently, it only works if the app is **i

- A valid `service-worker.js`.
- A valid web manifest (`manifest-webmanifest`). Don't forget to change the `start_url` property to the path of your app.
For instance, the following app hosted at https://dgranjon.shinyapps.io/rstudio-global-2021-calendar/, has the `/rstudio-global-2021-calendar/` path.
- As a bonus a valid `offline.html` fallback, which is displayed when the app is offline.
- A valid set of icons. There are tools such as [appsco](https://appsco.pe/developer/splash-screens) and [app-manifest](https://app-manifest.firebaseapp.com), to create
those custom icons and splash screens, if you need to.
Expand All @@ -100,7 +99,7 @@ The first step is to deploy your app somewhere. It doesn't matter where (shinyap
Then, you can follow these steps to install your app on your mobile device.

<br>
Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). In this example this is: https://dgranjon.shinyapps.io/miniUI2Demo/. It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI.
Copy the URL of your app in your mobile web browser (iOS: Safari and Andoid: Chrome). It opens like a classic web app, with top and bottom ugly navigation bars that are part of the browser UI.

- Select the share button located in the bottom bar of your iPhone/iPad For Android, you may do something similar. Importantly, Chrome for iOS does not support this feature, that's why we recommend using Safari.
- Click on "Add to Home Screen"
Expand Down
3 changes: 1 addition & 2 deletions vignettes/shinyMobile-tools.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ library(shiny)
library(shinyMobile)
preview_mobile(appPath = system.file("examples/gallery/app.R", package = "shinyMobile"), device = "iphoneX")
preview_mobile(url = "https://dgranjon.shinyapps.io/miniUI2DemoMd", device = "ipadMini")
# This also works with a remote app url hosted on shinyapps.io ...
```

The local preview is a 4 steps process:
Expand Down

0 comments on commit 42650f8

Please sign in to comment.