Add full Stackable functionality for UIStackView derivatives #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alias that doesn't get used. We need to remove it, or xcodebuild won't be able to parse schemes from Package.swift.
colejd
changed the title
|
Thanks @heyltsjay and @chrisballinger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you make a class deriving from
UIStackView, you don't get fullStackablefunctionality on it, as the various extensions in this library only apply to UIStackViews. This PR fixes this issue.Additionally, I wrote tests to support the development of this PR. To that end, I've added the test files as a target in the package itself. Because this gives us an easy point of entry for testing from the command line, I've also added automated testing via GitHub Actions.