-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds functionality to rebind keys to other keys #693
base: master
Are you sure you want to change the base?
Conversation
Those clippy errors don't have anything to do with my code and I don't feel like messing around with someone elses code, so that check can keep failing for all I care. |
The clippy errors are from the rust version upgrade to 1.49. Clippy got updated with that as well. The errors have nothing to do with your code. |
Sorry about the clippy errors. I've fixed them in #697. If you can rebase master, you should be good. I'll have a look at your changes as soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the PR and works as intended.
There are 3 trailing ';' that prevent cargo run to end without errors. Apart from that, all good.
@Rigellute run this:
And then
It literally took me 1 minute to have it working, and it's gonna be really useful for everyone. Thank you. |
The only thing missing would be the ability to rebind CTRL+key. This is something critical I wouldn't overlook. |
How is this project going ? |
abandoned |
This allows users to rebind keys to other keys in the config file which lets users with non-qwerty keyboards to use the vim-like keybinds. Users can also use this to change the keyboard shortcut for commands which are not configurable in the config file, although this is a somewhat clumsy way to do that. There is some awefully WET code in here (remap_key()), but it works.