Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds functionality to rebind keys to other keys #693

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Kagia001
Copy link

@Kagia001 Kagia001 commented Jan 3, 2021

This allows users to rebind keys to other keys in the config file which lets users with non-qwerty keyboards to use the vim-like keybinds. Users can also use this to change the keyboard shortcut for commands which are not configurable in the config file, although this is a somewhat clumsy way to do that. There is some awefully WET code in here (remap_key()), but it works.

@Kagia001 Kagia001 changed the title Adds function to rebind keys to other keys Adds functionality to rebind keys to other keys Jan 3, 2021
@Kagia001
Copy link
Author

Kagia001 commented Jan 3, 2021

#385

@Kagia001
Copy link
Author

Kagia001 commented Jan 3, 2021

Those clippy errors don't have anything to do with my code and I don't feel like messing around with someone elses code, so that check can keep failing for all I care.

@OrangeFran
Copy link
Contributor

The clippy errors are from the rust version upgrade to 1.49. Clippy got updated with that as well. The errors have nothing to do with your code.

@Rigellute
Copy link
Owner

Sorry about the clippy errors. I've fixed them in #697. If you can rebase master, you should be good.

I'll have a look at your changes as soon as I can.

Copy link

@Zeioth Zeioth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the PR and works as intended.

There are 3 trailing ';' that prevent cargo run to end without errors. Apart from that, all good.

@Zeioth
Copy link

Zeioth commented Jun 24, 2021

@Rigellute run this:

git fetch origin refs/pull/693/head:keybindings-rework
git clone git@github.com:Zeioth/spotify-tui.git 

And then

cargo run

It literally took me 1 minute to have it working, and it's gonna be really useful for everyone. Thank you.

@Zeioth
Copy link

Zeioth commented Jun 24, 2021

The only thing missing would be the ability to rebind CTRL+key. This is something critical I wouldn't overlook.

@gfauredev
Copy link

How is this project going ?
I would be interested in the rebind feature too.

@apprehensions
Copy link

How is this project going ?

abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants