Add ability to seek from the CLI #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed the clippy errors in #697, so you can rebase to remove those. I'll get to reviewing your changes as soon as I can. |
To jump forward, prepend a + to the number of seconds. To jump backwards, prepend a -. To jump to an absolute position, do not prepend anything.
Utilised by the `--seek` option.
…duration is bigger than the duration of the song
Rigellute
approved these changes
Jan 8, 2021
|
LGTM 👍 |
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
* Add new `--seek` to jump forward, backwards To jump forward, prepend a + to the number of seconds. To jump backwards, prepend a -. To jump to an absolute position, do not prepend anything. * Add new `%r` to the format options to display the current progress Utilised by the `--seek` option. * Add a longer help to the `--seek` option * Fix formatting * Add checks to prevent underflows + check to jump to next song if new duration is bigger than the duration of the song * Fix formatting * Fix clippy errors * Add more comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--seekto jump forward, backwards%rto the format options to display the current progress--seekoptionFor example:
spt pb --seek +10jumps ten second forwards,spt pb --seek -10ten seconds backwards andspt pb --seek 10to the tenth second of the track.