Support searching by Spotify share URLs and URIs analogously to the desktop client #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utagai
commented
Oct 16, 2020
Utagai
force-pushed
the
open-by-uri-or-url
branch
from
26c82b1
to
dfe9ba7
Compare
Utagai
changed the title
|
If you can please rebase, I'll merge! |
Unfortunately, I would have preferred the small refactor of adding process_input() to be in a separate commit, but I quite genuinely just forgot to commit my work, so these guys are mushed together here.
Albeit, not very cleanly. Want to try getting it nicer before I put this up...
Utagai
force-pushed
the
open-by-uri-or-url
branch
from
7a10957
to
31e1d2d
Compare
|
@Rigellute Done. |
|
Thanks again @Utagai |
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
…esktop client (Rigellute#623) * Generalize input processing to both URLs and URIs Unfortunately, I would have preferred the small refactor of adding process_input() to be in a separate commit, but I quite genuinely just forgot to commit my work, so these guys are mushed together here. * Add the boilerplate code for supporting tracks, playlists and podcasts * Introduce a spotify_resource_id() closure to reduce some duplication * Support searching playlists by URL/Spotify-URI * Support searching shows by URL/Spotify-URI * Support searching individual tracks by URL/Spotify-URI * Add initial parsing tests and required refactors * Add full suite of happy path test cases * Verify that we fail to match on invalid strings * Remove debug prints * Correct seek to track index on track search Albeit, not very cleanly. Want to try getting it nicer before I put this up... * Handle query parameters in URIs * Always push a GetPlaylist to the navigation stack to avoid UI inconsistency * Clear the playlist selection no matter what kind of search we do * Remove debug prints * Remove redundant clone * Prefer unwrap_or_else()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #41.
To be more precise, this actually adds significantly more functionality than what is requested in #41. In particular, this PR adds support for opening:
Via either their Spotify share URL, e.g.:
Or their Spotify URI:
On the official desktop client, searching with either of these leads you to the Metallica album, Metallica.
If the given input string fails to match either URI format, it will default to the original raw phrase search.
Here are some representative screenshots:
Press enter...
Note The highlighting/focusing of the track is automatically done.
There were some decisions I made in this PR that may be worth discussing. For those, I've let a comment.