Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make behavior of previous button mimic behavior in official Spotify client #219

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Make behavior of previous button mimic behavior in official Spotify client #219

merged 1 commit into from
Jan 26, 2020

Conversation

amgassert
Copy link
Contributor

@amgassert amgassert commented Jan 23, 2020 •
edited
Loading

This PR mimics the behavior of the previous button in the official client by only going to the previous track if current track time is under three seconds.

Alternative to #215
Closes #214

@amgassert amgassert changed the title Make behavior of previous button mimic behavior of official Spotify client Make behavior of previous button mimic behavior in official Spotify client Jan 23, 2020
Rigellute
Rigellute reviewed Jan 23, 2020
View reviewed changes
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I prefer this solution to the other PR. Good work 👍

Just one thing before I approve, would you be able to rebase the commits into one single commit?

@Rigellute Rigellute mentioned this pull request Jan 23, 2020
Closed
Rigellute
Rigellute approved these changes Jan 26, 2020
View reviewed changes
Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @amgassert 👍

@Rigellute Rigellute merged commit 193dfad into Rigellute:master Jan 26, 2020
@amgassert amgassert deleted the amgassert-reset-track-alt branch January 26, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigellute Rigellute Rigellute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reset track control
2 participants
@amgassert @Rigellute