-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow/unfollow artists #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
Could you add these new bindings to the help.rs
menu?
Added new bindings but some features are not implemented yet. I will soon implement them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I caused you a merge conflict.
If you could rebase and slightly modify the help
instruction?
Sorry for the bother!
src/ui/help.rs
Outdated
@@ -75,5 +75,15 @@ pub fn get_help_docs() -> Vec<Vec<&'static str>> { | |||
"<Ctrl+u>", | |||
"Pagination", | |||
], | |||
vec![ | |||
"Add selected artist, album, or track to the library", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, let's say only "Follow an artist"
Great work @echoSayonara! |
Add support for following/unfollowing artists.
Considering #152, it seems that adding/following and deleting/unfollowing have common components and there may be more good abstraction. I will try this after adding and deleting were implemented in other type contents.