Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagnation to user playlists #150

Merged
merged 7 commits into from
Nov 18, 2019
Merged

Added pagnation to user playlists #150

merged 7 commits into from
Nov 18, 2019

Conversation

Peterwmoss
Copy link
Contributor

Added some simple pagnation to at least scroll through your playlist. I don't know if this is the best way to implement it but it seems to work fine from my own testing. Please excuse if my Rust is "rusty", it's my first Rust project and I don't know if there is need for memory optimization for this change to not leak memory.

Copy link
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

Unfortunately, I've made a bit of a mess with regards to implementing pagination, which needs to be fixed.

But this looks fine for now.

Only thing to fix is the hardcoded offset

src/handlers/track_table.rs Outdated Show resolved Hide resolved
@Peterwmoss
Copy link
Contributor Author

I spotted a problem with the navigation when paging so I added a check to see if the new table should be added to the navigation stack.

@Rigellute
Copy link
Owner

Thanks for again for the contribution

@Rigellute Rigellute merged commit fa57961 into Rigellute:master Nov 18, 2019
@screamuch screamuch mentioned this pull request Dec 2, 2019
@Rigellute
Copy link
Owner

@all-contributors please add @Peterkmoss for code

@allcontributors
Copy link
Contributor

@Rigellute

I've put up a pull request to add @Peterkmoss! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants