Fix panic when seeking beyond track boundaries #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of attempting to seek beyond the end of the track, jump to the next track.
Rigellute
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Looks like Spotify itself was invoking the next track when being skipped to a greater length than the current track. https://developer.spotify.com/documentation/web-api/reference/player/seek-to-position-in-currently-playing-track/
But due to the 5 second polling for next playback, this must be unreliable and is indeed the cause of the bug you're fixing here.
So what you've done looks good.
Thank you for the contribution 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #123.
Not sure if there is an edge case to be concerned about:
If the user is at the end of a track and attempts to seek forward twice quickly (between ticks), it may be possible that
self.next_trackis called twice and playback unexpectedly skips forward two tracks instead of the one as expected.Am open to suggestions for better alternatives.