Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cargo/config.toml #696

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add .cargo/config.toml #696

wants to merge 3 commits into from

Conversation

racagogi
Copy link
Contributor

@racagogi racagogi commented Feb 2, 2025

Summary

rustc not use cmake LD_PATH see(#693 (comment))
thus, add config.toml to add link-args.
this solution work from stable to nightly rustc, rust-toolchain.toml can use stable channel.

Note

Checklist

  • I have documented my changes properly to adequate places
  • I have updated the docs/CHANGELOG.md

@jhhuh
Copy link

jhhuh commented Feb 5, 2025

To me, putting -Clink-args=-L./target/release in .cargo/config.toml doesn't seem appropriate since it was a very hacky way of making it just work for the nix build. It's only for release build, which is the only target nix build should care for.

A better fix might be with build.sh or build.rs. I may look for it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants