Check if docker image tags exist on lint #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
approved these changes
Nov 14, 2019
coderanger
approved these changes
Nov 14, 2019
avdhoot
reviewed
Nov 15, 2019
| if imageTags != nil { | ||
| var foundImage bool | ||
| for _, imageTag := range imageTags { | ||
| if summonObj.Spec.Version == imageTag { |
There was a problem hiding this comment.
Instead loop it will good if we use manifests api
GET | /v2/<name>/manifests/<reference> | Manifest | Fetch the manifest identified by name and reference where reference can be a tag or digest. A HEAD request can also be issued to this endpoint to obtain resource information without receiving all data.
There was a problem hiding this comment.
That would require 1 API call for every instance instead of getting list all at once and then checking. We could slightly speed this up by putting the image tags into a map[string]bool though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.