Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-3067 fix edit and lint issues #109

Merged
merged 16 commits into from
Apr 4, 2022
Merged

DEVOPS-3067 fix edit and lint issues #109

merged 16 commits into from
Apr 4, 2022

Conversation

kunalp-gohire
Copy link
Contributor

@kunalp-gohire kunalp-gohire commented Jan 7, 2022

Fixed below issues:

  • Lint: Detect wrong/duplicate summonplatform spec fields
  • Lint: Remove old SummonPlatform object support
  • Edit: Ignore error for objects which are not registered in scheme
  • Lint: Throw error if SummonPlatform yaml does not contain 1 or 3 objects (1 for namespace, 3 for namespace, SummonPlatform and EncryptedSecret)
  • Edit: Fix KeyId cannot be blank issue even if Data section has no key/value pairs to encrypt
  • Edit: Get KeyId while decrypting values, and use same for encrypting values
  • Edit: If there are multiple keyIds used in encryptedsecret, then select most used key to encrypt all values

@vivekjainx86 vivekjainx86 changed the title fix edit and lint issue DEVOPS-3067 fix edit and lint issue Mar 31, 2022
@vivekjainx86 vivekjainx86 changed the title DEVOPS-3067 fix edit and lint issue DEVOPS-3067 fix edit and lint issues Mar 31, 2022
@vivekjainx86 vivekjainx86 merged commit 8f0a5d5 into master Apr 4, 2022
@vivekjainx86 vivekjainx86 deleted the fix-edit-lint branch April 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants