Add support for System.Web.Mvc.AcceptVerbsAttribute to WebApiOpenApiDocumentGenerator #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Dec 25, 2022
…ocumentGenerator (RicoSuter#4104) * Add support for System.Web.Mvc AcceptVerbsAttribute * Add RouteTests for System.Web.Mvc AcceptVerbs
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Jan 20, 2024
…ocumentGenerator (RicoSuter#4104) * Add support for System.Web.Mvc AcceptVerbsAttribute * Add RouteTests for System.Web.Mvc AcceptVerbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed System.Web.Mvc.AcceptVerbsAttribute leads to an exception in WebApiOpenApiDocumentGenerator when determining HttpMethods. In case NSwag wants to support this, I would like to suggest this change. Please let me know if there are any improvements I can make or whether this is something you would not like to pursue.
Adds support for System.Web.Mvc.AcceptVerbsAttribute to WebApiOpenApiDocumentGenerator
#4103
WebApiOpenApiDocumentGenerator throws when encountering AcceptVerbsAttribute on projects using System.Web.Mvc.
httpMethods = acceptVerbsAttribute.HttpMethods is ICollectionSystem.Web.Mvc uses AcceptVerbsAttribute.Verbs-property instead of AcceptVerbsAttribute.HttpMethods-property used by ASP.NET Core.