Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated Microsoft.AspNetCore.* #3366

Merged

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Mar 17, 2021

Hi, this PR add new targets netcoreapp3.1;net5.0 in NSwag.AspNetCore so it can remove dependency on obsolete packages (Microsoft.AspNetCore.Mvc.Core, Microsoft.AspNetCore.Mvc.Formatters.Json, Microsoft.AspNetCore.StaticFiles)

@trejjam trejjam force-pushed the feature/drop-deprecated-packages branch 2 times, most recently from a8713a3 to 5822c28 Compare March 17, 2021 22:48
@trejjam trejjam force-pushed the feature/drop-deprecated-packages branch from 5822c28 to b2805c2 Compare March 17, 2021 22:59
@@ -63,6 +68,10 @@
<ProjectReference Include="..\NSwag.Generation\NSwag.Generation.csproj" />
</ItemGroup>

<ItemGroup>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be removed, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, removed.

Sorry for the delay, I was out of the keyboard.

@RicoSuter RicoSuter merged commit 0bab282 into RicoSuter:master Apr 8, 2021
@trejjam trejjam deleted the feature/drop-deprecated-packages branch April 8, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants