-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated Microsoft.AspNetCore.* #3366
Merged
RicoSuter
merged 9 commits into
RicoSuter:master
from
trejjam:feature/drop-deprecated-packages
Apr 8, 2021
Merged
Drop deprecated Microsoft.AspNetCore.* #3366
RicoSuter
merged 9 commits into
RicoSuter:master
from
trejjam:feature/drop-deprecated-packages
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trejjam
force-pushed
the
feature/drop-deprecated-packages
branch
2 times, most recently
from
March 17, 2021 22:48
a8713a3
to
5822c28
Compare
trejjam
force-pushed
the
feature/drop-deprecated-packages
branch
from
March 17, 2021 22:59
5822c28
to
b2805c2
Compare
RicoSuter
reviewed
Mar 23, 2021
@@ -63,6 +68,10 @@ | |||
<ProjectReference Include="..\NSwag.Generation\NSwag.Generation.csproj" /> | |||
</ItemGroup> | |||
|
|||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be removed, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, removed.
Sorry for the delay, I was out of the keyboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR add new targets
netcoreapp3.1;net5.0
inNSwag.AspNetCore
so it can remove dependency on obsolete packages (Microsoft.AspNetCore.Mvc.Core
,Microsoft.AspNetCore.Mvc.Formatters.Json
,Microsoft.AspNetCore.StaticFiles
)