fixes #1728 return null when subType is not found, fixes Stackoverflow exception #1729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1728
I do not know how to test it. The generated code in the liquid file is not the same as the 'real'
NJsonSchema.Converters.JsonInheritanceConverter<TBase>
, which has tests.Also the 'real' code of
GetObjectSubtype
returns a null value when subType is not found.so the fix got to be right! ;)