New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdditionalProperties are only added on the base class #1451

Merged

RicoSuter merged 3 commits into RicoSuter:master from jochenjonc:master

Dec 14, 2021

Contributor

jochenjonc commented Nov 30, 2021

PR for #1447


          AdditionalProperties are only added on the base class

809e4b2

Owner

RicoSuter commented Dec 14, 2021

I think this is not the right solution:

What if the base class does not allow additional properties only the subclass?
What about a bigger inheritance tree?


          Use base class

2d51472

Owner

RicoSuter commented Dec 14, 2021

Updated to use BaseClass instead, should cover these scenarios.


          add comment

aca2f9c

RicoSuter merged commit 65dec69 into RicoSuter:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet