fix(Block): added relation resolution to Block's inverseRelation method #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicLeP
approved these changes
Sep 6, 2024
|
@codyworthen thanks for this, merging now and will release soon. Sorry for the delay - school summer holidays here. The inverse relations are something I definitely am looking to enhance as they can be a performance hit at times when there are lots of related pages, or chained relations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that it's useful to have
Block.php's inverseRelation method accept an argument for resolving relations, both for "real" storyblok api requests, as well as when dealing with Live Editor JSON that may come from storyblok because storyblok doesn't resolve relations by default.