Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): 💡 Removed unnecessary Writer #615

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Aug 10, 2024

Purpose of this Pull Request

Described in the title.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 10, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 10, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.47%. Comparing base (5803a76) to head (ab9d5a3).
Report is 8 commits behind head on master.

Files Patch % Lines
core/src/animation/stagger.rs 75.00% 1 Missing ⚠️
core/src/animation/transition.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   84.02%   83.47%   -0.55%     
==========================================
  Files         185      185              
  Lines       25420    25585     +165     
==========================================
- Hits        21359    21358       -1     
- Misses       4061     4227     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 10, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 10, 2024
@M-Adoo M-Adoo merged commit ca5ea05 into RibirX:master Aug 10, 2024
7 of 9 checks passed
@M-Adoo M-Adoo deleted the feat/remove-writer branch August 10, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant