Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm(64)/dts/connect4: Reduce SPI frequency of KSZ9897 #30

Merged
merged 1 commit into from
Aug 9, 2021
Merged

arm(64)/dts/connect4: Reduce SPI frequency of KSZ9897 #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion arch/arm/boot/dts/overlays/revpi-connect4-overlay.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,12 @@
ksz9897: ksz9897@0 {
compatible = "microchip,ksz9897";
reg = <0>;
spi-max-frequency = <50000000>;
/*
* Limit frequency to 25MHz to avoid data
* corruption due to interferences with USB
* signals.
*/
spi-max-frequency = <25000000>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment in the file as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, makes sense

spi-cpha;
spi-cpol;
reset-gpios = <&expander_core 13 GPIO_ACTIVE_LOW>;
Expand Down