Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always reload customerInfo when Customer Center is loaded #4575

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

fire-at-will
Copy link
Contributor

Description

This PR makes it so that we always reload the CustomerInfo from the backend when the Customer Center appears

@@ -23,7 +23,9 @@ protocol CustomerCenterPurchasesType: Sendable {
var isSandbox: Bool { get }

@Sendable
func customerInfo() async throws -> CustomerInfo
func customerInfo(
fetchPolicy: CacheFetchPolicy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make this default to .default, but Swift doesn't allow default values in protocols 😅

@fire-at-will fire-at-will marked this pull request as ready for review December 11, 2024 20:43
@fire-at-will fire-at-will requested review from vegaro and a team December 11, 2024 20:43
@fire-at-will fire-at-will merged commit fa27846 into main Dec 11, 2024
10 checks passed
@fire-at-will fire-at-will deleted the always-reload-customer-info branch December 11, 2024 20:45
@vegaro vegaro added pr:fix A bug fix and removed pr:other labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants