Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide mode from public init in CustomerCenterView #4563

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Hide mode from public init in CustomerCenterView #4563

merged 1 commit into from
Dec 10, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Dec 9, 2024

Hides the mode parameter from the public constructor. This is really only used for the presentCustomerCenterView functions

@vegaro vegaro requested a review from a team December 9, 2024 16:15
fire-at-will
fire-at-will approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@fire-at-will fire-at-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - this breaking change reminds me that we should come back and add in API tests for this view in the future 🧑‍💻

@vegaro vegaro merged commit a55a21d into main Dec 10, 2024
10 checks passed
@vegaro vegaro deleted the hide-mode-from-public branch December 10, 2024 09:35
This was referenced Dec 11, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire-at-will fire-at-will fire-at-will approved these changes

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
feat:Customer Center pr:other pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vegaro @tonidero @fire-at-will