Fix iOS 15 tests #4320
Merged
Fix iOS 15 tests #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
joshdholtz
approved these changes
Sep 27, 2024
aboedo
approved these changes
Sep 27, 2024
tonidero
approved these changes
Sep 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
vegaro
commented
Sep 30, 2024
|
|
||
| self.mockDiagnosticsTracker = MockDiagnosticsTracker() | ||
| } | ||
|
|
||
| func testFetchProductsWithIdentifiersSK2TracksCorrectly() throws { |
There was a problem hiding this comment.
isStoreKit2Available is always false for iOS < 16, so this test was running with storeKit1 even after configuring the manager using SK2
|
@RCGitBot please test |
tonidero
approved these changes
Sep 30, 2024
| @@ -159,14 +159,12 @@ private extension DiagnosticsTracker { | |||
| func clearDiagnosticsFileIfTooBig() async { | |||
| if await self.diagnosticsFileHandler.isDiagnosticsFileTooBig() { | |||
| await self.diagnosticsFileHandler.emptyDiagnosticsFile() | |||
| self.trackMaxEventsStoredLimitReached() | |||
| await self.clearDiagnosticsFileIfTooBig() | |||
There was a problem hiding this comment.
Hmm is this needed? I guess when calling this, since we just emptied the file in the line above, it shouldn't do anything, but shouldn't be needed normally?
There was a problem hiding this comment.
not needed right. I forgot to remove this line when copying the content of track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
MockOperationDispatcherclass in theTests/UnitTests/Mocks/MockOperationDispatcher.swiftfile to improve the handling of asynchronous tasks. The most important change is the replacement of a semaphore with a dispatch group to ensure the async task completes before proceeding.It looks like the semaphore was causing issues in iOS 15, making the test forever