Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an onDismiss callback to ErrorDisplay #4312

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Adds an onDismiss callback to ErrorDisplay #4312

merged 1 commit into from
Sep 27, 2024

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Sep 27, 2024 •
edited
Loading

As the title says, and as discussed on Slack. This is needed for RevenueCat/purchases-kmp#217.

@JayShortway JayShortway self-assigned this Sep 27, 2024
@JayShortway JayShortway added pr:other pr:force_minor Forces a minor release labels Sep 27, 2024
@JayShortway
Copy link
Member Author

Not sure about the labels. Went with force_minor because it's not a bug fix, and SemVer says patch is for bug fixes only. Open to suggestions.

@JayShortway
Copy link
Member Author

@RCGitBot please test

@JayShortway JayShortway marked this pull request as ready for review September 27, 2024 12:06
@JayShortway JayShortway requested review from joshdholtz, fire-at-will and a team September 27, 2024 12:06
joshdholtz
joshdholtz approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! :shipit:

@joshdholtz joshdholtz changed the title Adds an onDismiss callback to ErrorDisplay. Adds an onDismiss callback to ErrorDisplay Sep 27, 2024
@JayShortway JayShortway added pr:force_patch Forces a patch release and removed pr:force_minor Forces a minor release labels Sep 27, 2024
@JayShortway
Copy link
Member Author

Changed it back to force_patch haha. It kinda is a bug fix, but for purchases-kmp. Still open to suggestions.

@JayShortway JayShortway merged commit c4d50d3 into main Sep 27, 2024
32 of 33 checks passed
@JayShortway JayShortway deleted the errordisplay-callback branch September 27, 2024 14:51
@RCGitBot RCGitBot mentioned this pull request Sep 30, 2024
Closed
nyeu pushed a commit that referenced this pull request Oct 2, 2024
@JayShortway @nyeu
Adds an onDismiss callback to ErrorDisplay. (#4312)
fa11f0b
@JayShortway JayShortway mentioned this pull request Oct 10, 2024
Merged
MojtabaHs pushed a commit to MojtabaHs/purchases-ios that referenced this pull request Dec 12, 2024
@JayShortway @MojtabaHs
Adds an onDismiss callback to ErrorDisplay. (RevenueCat#4312)
f875962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

@fire-at-will fire-at-will Awaiting requested review from fire-at-will

Assignees

@JayShortway JayShortway

Labels
pr:force_patch Forces a patch release pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayShortway @joshdholtz