Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More customer center docs and fix init #4304

Merged
merged 2 commits into from
Sep 26, 2024
Merged

More customer center docs and fix init #4304

merged 2 commits into from
Sep 26, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Sep 26, 2024

  • Noticed the public init contained CustomerCenterConfigData.Localization and CustomerCenterConfigData.Appearance
  • Improved public docs

appearance: CustomerCenterConfigData.Appearance = .default) {
/// - Parameters:
/// - customerCenterActionHandler: An optional `CustomerCenterActionHandler` to handle actions from the customer center.
public init(customerCenterActionHandler: CustomerCenterActionHandler? = nil) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is theoretically a breaking change... But I'm ok with it since this is still on beta only :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, if someone was using it, they shouldn't have lol

@vegaro vegaro merged commit fb15e2a into main Sep 26, 2024
5 checks passed
@vegaro vegaro deleted the customer-center-docs branch September 26, 2024 17:08
@vegaro vegaro mentioned this pull request Sep 27, 2024
nyeu pushed a commit that referenced this pull request Oct 2, 2024
MojtabaHs pushed a commit to MojtabaHs/purchases-ios that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants