Round price per period calculations to nearest 2-decimal #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
round-prices-nearest-2-decimal
branch
from
eb33e8c to
4f5d03b
Compare
|
Need to update snapshots |
This was referenced Sep 18, 2024
11 tasks
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Round price per period calculations to nearest 2-decimal * Fix tests * Update snapshots commit
MojtabaHs
pushed a commit
to MojtabaHs/purchases-ios
that referenced
this pull request
Dec 12, 2024
…4275) * Round price per period calculations to nearest 2-decimal * Fix tests * Update snapshots commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were rounding the price per period calculations to the floor of the second decimal of the price. This changes it to round to the closest number following the logic in: https://developer.apple.com/documentation/foundation/nsdecimalnumber/roundingmode
This might help with #4246