Remove usage of adServicesToken in syncPurchases #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrb1
approved these changes
Sep 10, 2024
aboedo
approved these changes
Sep 10, 2024
NachoSoto
approved these changes
Sep 10, 2024
This was referenced Sep 11, 2024
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
### Checklist
- [ ] If applicable, unit tests
- [ ] If applicable, create follow-up issues for `purchases-android` and
hybrids
### Motivation
The AdServicesToken wasn't being sent to the the post receipt endpoint
when syncing purchases, but was marking it as synced, so better to
remove it altogether.
### Description
Removed usage of adServicesToken in syncPurchases.
The diff is a mess even in split mode. The changes are the same in the
`syncPurchasesSK1` and `syncPurchasesSK2` methods:
- The following line was removed:
```
self.attribution.unsyncedAdServicesToken { adServicesToken in
```
- The `adServicesToken` parameter was changed to nil:
```
adServicesToken: nil
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
The AdServicesToken wasn't being sent to the the post receipt endpoint when syncing purchases, but was marking it as synced, so better to remove it altogether.
Description
Removed usage of adServicesToken in syncPurchases.
The diff is a mess even in split mode. The changes are the same in the
syncPurchasesSK1andsyncPurchasesSK2methods:adServicesTokenparameter was changed to nil: