Expose iOS PurchaseParamsBuilder API to KMP #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
approved these changes
Jan 27, 2025
Comment on lines
+15
to
+18
| // PurchaseParams.Builder isn't exposed as a part of the PHC's public API to KMP by default. | ||
| // We can expose it by adding this function to the PurchaseParams.Builder class. This function is intentionally a no-op | ||
| // and shouldn't be called anywhere but also shouldn't be removed without ensuring that the PurchaseParams.Builder | ||
| // class is exposed to KMP in some other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing
RCPurchaseParamsBuilderFor some reason, the
RCPurchaseParamsBuilderclass from the native iOS SDK isn't exposed by PHC's API to the KMP SDK by default. We're able to force it to be available by adding a publicnoOPfunction in an extension at the PHC level.This PR exposes the
RCPurchaseParamsBuilderclass from the native iOS SDK through the PHC API by adding a publicnoOPfunction to the builder class.Other Approaches Considered
RCPurchaseParamsBuilderas a typealias since swift typealiases aren’t available in obj-cRCPurchaseParamsandRCPurchaseParamsBuilderdirectly classes into PHC, and when the classes are located there,RCPurchaseParamsBuilderis accessible without any additional extension shenanigans, but this still doesn't explain why the originalRCPurchaseParamsBuilderclass is unavailable.