Fix saving of settings when pressing ESC #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
fix-esc-handling
branch
from
50240ae to
43137cf
Compare
When pressing ESC the window was directly deleted instead of first calling Close which triggers a settings update for e.g. the tools window. Refactor this so deleting a window is purely done by the WindowManager and before deleting Close is always called. Add tests which catch this. Also some changes to tests to avoid log spam and fix possibly missed mock-verify calls.
Flamefire
force-pushed
the
fix-esc-handling
branch
from
43137cf to
a952385
Compare
Flow86
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing ESC the window was directly deleted instead of first calling Close which triggers a settings update for e.g. the tools window.
Refactor this so deleting a window is purely done by the WindowManager and before deleting Close is always called.
Add tests which catch this.
Also some changes to tests to avoid log spam and fix possibly missed mock-verify calls.
Fixes #1455