Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High terrrain values are not rendered #1444

Closed
SupanovaHS opened this issue Oct 8, 2021 · 6 comments · Fixed by #1448
Closed

High terrrain values are not rendered #1444

SupanovaHS opened this issue Oct 8, 2021 · 6 comments · Fixed by #1448

Comments

@SupanovaHS
Copy link

Using the random map generator on max size caused a large black void in the terrain renderer.

void GameWorldView::CalcFxLx() seems to contain a hard cap of 60, rasing this higer fixes the issue .

GameWorldView.cpp line 615

I would raise a pull request but I don't know enough of the project to warrent why this was set to 60 in the first place, all I know is rasing this to 200 fixed my issue

@Flamefire
Copy link
Member

Could you attach the map which is causing this issue and the coordinates where it occurs?

@SupanovaHS
Copy link
Author

SupanovaHS commented Oct 24, 2021

Any 1024x1024 random map, and look at the top of the mountain range caused this for me.....

link to my fork to fix 3fd66fe

@SupanovaHS
Copy link
Author

The editor has the same issue when u load in a 1024x1024 randomly generated map

@Flamefire
Copy link
Member

Yeah, but attaching a map helps us to reproduce this faster.

@SupanovaHS
Copy link
Author

AIv3.zip

Flamefire added a commit to Flamefire/s25client that referenced this issue Oct 26, 2021
Replace hard-coded max height of 60 by calculated height
Fixes Return-To-The-Roots#1444
@Flamefire
Copy link
Member

Thanks for that. Found the problem and fixed in in the client and editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants