Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German Localization #46

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Add German Localization #46

merged 2 commits into from
Jul 11, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented Jul 9, 2024

Some of the keys could be removed too ... sadly the settings don't (yet) show descriptions for display items or groups either :/

@Banane9 Banane9 added the enhancement New feature or request label Jul 9, 2024
ColinTimBarndt
ColinTimBarndt requested changes Jul 11, 2024
View reviewed changes
Copy link

@ColinTimBarndt ColinTimBarndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments on minor grammatical errors, and I think the changes to the English localization shouldn't be in a PR for the German one.

MonkeyLoader.Resonite.Integration/Locale/de.json Outdated Show resolved Hide resolved
MonkeyLoader.Resonite.Integration/Locale/en.json Outdated Show resolved Hide resolved
MonkeyLoader.Resonite.Integration/Locale/de.json Outdated Show resolved Hide resolved
MonkeyLoader.Resonite.Integration/Locale/de.json Outdated Show resolved Hide resolved
ColinTimBarndt
ColinTimBarndt approved these changes Jul 11, 2024
View reviewed changes
Copy link

@ColinTimBarndt ColinTimBarndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 😄

@Banane9 Banane9 merged commit bfc3ae5 into master Jul 11, 2024
2 checks passed
@Banane9 Banane9 deleted the feature/add-german-localization branch July 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinTimBarndt ColinTimBarndt ColinTimBarndt approved these changes

@mpmxyz mpmxyz Awaiting requested review from mpmxyz

@phil-flip phil-flip Awaiting requested review from phil-flip

@ErrorJan ErrorJan Awaiting requested review from ErrorJan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Banane9 @ColinTimBarndt