Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override OnShutdown in ResoniteEventHandlers #42

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

Nytra
Copy link
Contributor

@Nytra Nytra commented Jul 3, 2024

Closes #41 maybe?

@Nytra Nytra requested a review from Banane9 July 3, 2024 11:22
@Banane9
Copy link
Member

Banane9 commented Jul 3, 2024

Hmmmm, what's with the extra commits in the PR? 🤔

Also please add the documentation as well - ideally "Unregisters" could link to the right Mod.UnregisterEventHandler method:

        /// <remarks>
        /// <i>By default:</i> Unregisters this monkey as an event handler for <typeparamref name="TEvent">s
        /// and removes all <see cref="HarmonyLib.Harmony"/> patches done
        /// using this Monkey's <see cref="Harmony">Harmony</see> instance,
        /// if not exiting, and returns <c>true</c>.
        /// </remarks>
        /// <inheritdoc/>

@Nytra
Copy link
Contributor Author

Nytra commented Jul 3, 2024

Those extra commits are just leftovers in my branch and I don't know how to get rid of them :P They don't contain any changes.

Or rather the changes from them are cancelled out

@Banane9
Copy link
Member

Banane9 commented Jul 3, 2024

Hmmm, not sure, I've had that happen before too, I think.

You can push your changes right to this repository too though, if you want.

@Nytra
Copy link
Contributor Author

Nytra commented Jul 3, 2024

Yeah I probably should do that in the future

@Banane9 Banane9 merged commit b71a4df into ResoniteModdingGroup:master Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The various (Configured)ResoniteEventHandler don't override OnShutdown to unregister the event handlers
2 participants