Make ConfigKeySessionShare more resilient

ResoniteModdingGroup · Aug 2, 2024 · 5dc542a · 5dc542a
1 parent 7a5e1ee
commit 5dc542a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/MonkeyLoader.Resonite.Integration/Configuration/ConfigKeySessionShare.cs b/MonkeyLoader.Resonite.Integration/Configuration/ConfigKeySessionShare.cs
@@ -18,7 +18,6 @@ namespace MonkeyLoader.Resonite.Configuration
     /// <typeparam name="T">The type of the config item's value.</typeparam>
     public sealed class ConfigKeySessionShare<T> : IConfigKeySessionShare<T>
     {
-        private readonly ConditionalWeakTable<World, object?> _didWorldSetup = new();
         private readonly Lazy<string> _sharedId;
         private readonly Lazy<string> _variableName;
         private IDefiningConfigKey<T> _configKey = null!;
@@ -134,13 +133,10 @@ private ValueUserOverride<T> GetSharedOverride(World world)
             => GetSharedValue(world).Value.GetUserOverride();
 
         private ValueField<T> GetSharedValue(World world)
-            => world.GetSharedComponentOrCreate<ValueField<T>>(SharedId, SetupSharedField, 0, true, true, () => GetSharedConfigSlot(world));
+            => world.GetSharedComponentOrCreate<ValueField<T>>(SharedId, SetupSharedField, 0, true, false, () => GetSharedConfigSlot(world));
 
         private void SetupSharedField(ValueField<T> field)
         {
-            if (_didWorldSetup.TryGetValue(field.World, out _))
-                return;
-
             if (!field.IsDriven && EqualityComparer<T>.Default.Equals(field.Value, default!))
                 field.Value.Value = DefaultValue!;
 
@@ -150,8 +146,6 @@ private void SetupSharedField(ValueField<T> field)
             vuo.CreateOverrideOnWrite.Value = true;
 
             field.Value.OnValueChange += SharedValueChanged;
-
-            _didWorldSetup.TryAdd(field.World, null);
         }
 
         private void SharedValueChanged(SyncField<T> field)

diff --git a/MonkeyLoader.Resonite.Integration/MonkeyLoader.Resonite.Integration.csproj b/MonkeyLoader.Resonite.Integration/MonkeyLoader.Resonite.Integration.csproj
@@ -10,7 +10,7 @@
     <PackageId>MonkeyLoader.GamePacks.Resonite</PackageId>
     <Title>Resonite Game Pack</Title>
     <Authors>Banane9, Nytra</Authors>
-    <Version>0.18.0-beta</Version>
+    <Version>0.18.0-beta-pre1</Version>
     <Description>
       This Game Pack for MonkeyLoader provides basic hooks for modding the game Resonite,
       which uses FrooxEngine. It provides hooks for the beginning of initialization,