Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Dynamic selectors #2

Merged
merged 189 commits into from
Nov 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
189 commits
Select commit Hold shift + click to select a range
60f32b8
Add "Maximum Products to Show" setting to Product Recommendations sec…
sofiamatulis Mar 4, 2022
7516fb1
Add missing gradient support (#1304)
kmeleta Mar 4, 2022
622e859
Fix password page email signup input (#1421)
Mar 4, 2022
f2f8ab7
Setup theme-check GitHub annotations (#1422)
charlespwd Mar 8, 2022
a233886
test something real quick (#1467)
charlespwd Mar 8, 2022
95c5e93
Cleanup product media grid spacing (#1444)
kmeleta Mar 8, 2022
3bce717
Update color list order and simplify section string (#1413)
melissaperreault Mar 8, 2022
94e859a
Add mega menu (#1316)
KaichenWang Mar 9, 2022
71762f7
Update translations: merchant (#1474)
translation-platform[bot] Mar 10, 2022
4c4c2ea
Update 1 translation file (#1475)
translation-platform[bot] Mar 10, 2022
da38d41
Center align payment terms form text when there is no image (#1473)
taliahm Mar 10, 2022
c3b79f4
Add grid settings to collections list (#1469)
sofiamatulis Mar 11, 2022
44aae04
Feat. collection updates (#1295)
ludoboludo Mar 11, 2022
5edb3be
Update 20 translation files (#1487)
translation-platform[bot] Mar 14, 2022
ab607b9
Theme check manual fixes (#1379)
Mar 15, 2022
b2083ac
Clean up behaviour when there are only L2 links mega menu (#1492)
sofiamatulis Mar 15, 2022
a3c30ed
Center mega menu (#1482)
sofiamatulis Mar 15, 2022
33c425c
Update 1 translation file (#1499)
translation-platform[bot] Mar 16, 2022
1a858ac
Video alt text info content update (#935)
melissaperreault Mar 16, 2022
7dd433a
Adjust color contrast for Vendor on the cart page (#1462)
ludoboludo Mar 16, 2022
7cb41df
Add support for boolean filters (#1456)
carolineschnapp Mar 16, 2022
db557f9
Fixed condensed mega menu (#1504)
tyleralsbury Mar 17, 2022
25faebe
Fixed bug where product page thumbnail slider arrows were appearing w…
tyleralsbury Mar 18, 2022
7e26c11
Fixed multicolumn gap spacing on mobile (#1505)
tyleralsbury Mar 18, 2022
6fcf0e1
Fixed max price display on filter drawer (#1512)
tyleralsbury Mar 18, 2022
67e7753
Theme check TemplateLength (#1511)
Mar 18, 2022
98ef025
Add PR checkbox for theme documentation (#1516)
martinamarien Mar 21, 2022
3e5c4f8
Update 1 translation file (#1517)
translation-platform[bot] Mar 22, 2022
50a8351
Update 1 translation file (#1528)
translation-platform[bot] Mar 23, 2022
87b8b9d
Update 1 translation file (#1533)
translation-platform[bot] Mar 24, 2022
2052324
Update 1 translation file (#1536)
translation-platform[bot] Mar 25, 2022
2920bbf
Quick Add (#1388)
LucasLacerdaUX Mar 28, 2022
a44d420
Featured Collection : Fix max width setting (#1538)
LucasLacerdaUX Mar 28, 2022
d36a504
Fix product rating help doc links (#1532)
melissaperreault Mar 28, 2022
e25736b
Prevent empty heading in contact form (#1515)
kmeleta Mar 29, 2022
ff2a770
Move slideshow control buttons when set to autorotate (#1523)
ludoboludo Mar 29, 2022
0f96850
Update 1 translation file (#1554)
translation-platform[bot] Mar 30, 2022
e9c6831
Hide inactive mobile menu items from screen readers (#1493)
kmeleta Mar 30, 2022
19c3719
Vertical filter (#1443)
sofiamatulis Mar 30, 2022
42ccea6
Remove transforms from image with text content (#1560)
kmeleta Mar 31, 2022
d04f943
Fix shop link on giftcard page (#1557)
bredowmax Mar 31, 2022
72091ed
Using font size and spacing for mega menu hierarchy (#1520)
tyleralsbury Apr 4, 2022
46bd4d7
Update translations: buyer (#1581)
translation-platform[bot] Apr 4, 2022
b55668b
Quick Add: Fix button overflow on mobile carousel (#1567)
LucasLacerdaUX Apr 5, 2022
c60f8ce
Update spacing (#1588)
LucasLacerdaUX Apr 6, 2022
d37c2e0
Vertical filter UX follow ups (#1568)
sofiamatulis Apr 6, 2022
3591cdf
Version bump v5.0.0 (#1624)
LucasLacerdaUX Apr 15, 2022
64aa07f
Remove unused setting (#1617)
LucasLacerdaUX Apr 20, 2022
3549f96
Update 5 translation files (#1626)
translation-platform[bot] Apr 20, 2022
b1fd9b4
Update 1 translation file (#1634)
translation-platform[bot] Apr 25, 2022
17c4b67
Remove recaptcha visibility hidden on contact form (#1637)
martinamarien Apr 25, 2022
e5de9f1
Fix Product strucure-data markup for Brand property (#1600)
antoniojhun Apr 26, 2022
cc2cf29
Fix empty collection links (#1639)
Apr 26, 2022
af58b34
Fix first image lazy load on main product section (#1286)
baldurh Apr 27, 2022
a8ded52
replace the hex code by currentColor (#1591)
melissaperreault May 4, 2022
dcf6e50
Cart drawer (#1544)
tyleralsbury May 6, 2022
504102e
Fix button spinner in Safari (#1646)
mashkovtsevlx May 6, 2022
2d5a857
Rich text improvements (#1635)
May 6, 2022
984e244
[Header] add setting to tweak top and bottom padding (#1654)
LucasLacerdaUX May 11, 2022
93c4a34
Update translations: buyer (#1659)
translation-platform[bot] May 12, 2022
823b21f
Update translations: merchant (#1681)
translation-platform[bot] May 12, 2022
8db40b6
Remove gradient when slide container is set to be hidden on desktop (…
ludoboludo May 12, 2022
d4abfde
Revert flex grow on collage card__content (#1662)
ludoboludo May 13, 2022
c8881c5
Update minimum header padding to zero (#1688)
LucasLacerdaUX May 13, 2022
98330b0
Fix a typo in main-product.liquid (#1647)
leesiongchan May 13, 2022
f7e16a9
1-click Quick Add for products with 1 non-default variant (#1610)
bredowmax May 16, 2022
9669caf
Update spacing below product media (#1689)
LucasLacerdaUX May 16, 2022
ff77d3d
Revert button type and button 1 ids (#1705)
martinamarien May 18, 2022
a592814
Update Banner image and logo Image to use `image_tag` (#1701)
sofiamatulis May 18, 2022
ca84837
Fix product media slider peek (#1696)
kmeleta May 18, 2022
98e23e0
Remove alt text to improve screen reader experience (#1679)
pizzaz93 May 18, 2022
bf3fa24
Update Subtotal header for a11y (#1680)
pizzaz93 May 18, 2022
21ab9d8
Remove extra whitespace on Quick Add modals (#1706)
LucasLacerdaUX May 19, 2022
67eb904
Update 1 translation file (#1715)
translation-platform[bot] May 20, 2022
945bb64
[Collapsible content] Add vertical padding to blocks (#1655)
LucasLacerdaUX May 24, 2022
eb29b18
Fix syntax error caused by missing calc in product CSS (#1703)
boltgolt May 24, 2022
81b6818
Update 1 translation file (#1739)
translation-platform[bot] May 26, 2022
9338f9c
Cart drawer section fix (#1742)
ludoboludo May 30, 2022
e36aa68
Update translations: merchant (#1757)
translation-platform[bot] Jun 2, 2022
708729f
Version bump v6.0.0 (#1769)
martinamarien Jun 7, 2022
f647405
Fix box shadow being cut off on sliders (#1772)
LucasLacerdaUX Jun 9, 2022
e990e8e
Update contact-form.liquid (#1716)
pizzaz93 Jun 10, 2022
dc397ff
Update main-cart-items.liquid (#1717)
pizzaz93 Jun 10, 2022
21468ab
Update main-collection-banner.liquid (#1718)
pizzaz93 Jun 10, 2022
a698b09
Remove menu title requirement (#1763)
Jun 13, 2022
8d0e9fb
Badge padding update (#1785)
Oliviammarcello Jun 14, 2022
3b7a682
Add video button aria label (#1728)
pizzaz93 Jun 20, 2022
2337de0
Change aria for active pagination nav control (#1727)
pizzaz93 Jun 20, 2022
050c7b1
Update 1 translation file (#1809)
translation-platform[bot] Jun 20, 2022
c101242
Warn users that link opens in a new window (#1735)
pizzaz93 Jun 21, 2022
b9b7f02
Add unique ids to card-product.liquid headings and product state badg…
pizzaz93 Jun 21, 2022
989f485
Badge product card position copy update (#1795)
Oliviammarcello Jun 21, 2022
6942f02
Distinct View All IDs for screen readers (#1733)
pizzaz93 Jun 22, 2022
a8a42d0
Fix Quick Add when cart type is set to Page (remove data-cart-type) (…
LucasLacerdaUX Jun 22, 2022
e480227
Replaced a missing </div> tag in main-search.liquid (#1804)
Jun 22, 2022
b7d4d70
version bump to 6.0.2 (#1819)
ludoboludo Jun 22, 2022
164b77d
Add help text to the Variant Pills settings area (#1782)
kjellr Jun 27, 2022
6b57f75
Update translations: buyer (#1828)
translation-platform[bot] Jun 28, 2022
67a3c4f
Update translations: merchant (#1818)
translation-platform[bot] Jun 28, 2022
d0463c6
Remove duplicate .hidden class in base.css (#1811)
LeafedFox Jun 29, 2022
20886d0
Setting border-top to 0.1rem to match with header navigation (#1802)
danielvann777 Jun 29, 2022
ba8b108
Add period to Cart global setting info text (#1751)
melissaperreault Jul 1, 2022
be79c4c
Add focus ring/border in Windows High Contrast mode (#1729)
pizzaz93 Jul 4, 2022
0c675f7
Update 1 translation file (#1836)
translation-platform[bot] Jul 4, 2022
13a3d40
Announcment alignment (#1770)
Jul 4, 2022
3fbabdc
Add pagination to main collection list (#1745)
ludoboludo Jul 5, 2022
627bb72
Jsonify customer sections (#1640)
tyleralsbury Jul 7, 2022
bf4e7d3
Update translations: merchant (#1843)
translation-platform[bot] Jul 8, 2022
70621f9
Update 1 translation file (#1849)
translation-platform[bot] Jul 12, 2022
b18d1be
Update PULL_REQUEST_TEMPLATE.md
ludoboludo Jul 12, 2022
b7038b4
Remove CLA from probot and use new GitHub action (#1859)
cursedcoder Jul 20, 2022
af705f4
Update 1 translation file (#1862)
translation-platform[bot] Jul 25, 2022
2afabc1
Add `reopened` activity type (#1874)
Jul 25, 2022
6e513c5
add vendor to popup notification when vendor checkbox is checked (#1870)
metamoni Jul 26, 2022
63f527f
Add proper product title to data-shopify-title (#1858)
ludoboludo Jul 27, 2022
d9cff51
Update 1 translation file (#1872)
translation-platform[bot] Jul 27, 2022
45f621b
Use param_name instead of label to construct an id for filter values …
carolineschnapp Jul 28, 2022
f1bd268
Fix linting issues in feature-product and main-product sections (#1873)
metamoni Jul 29, 2022
c341b54
[Card Settings] Break card global settings into Blog, Collection and …
sofiamatulis Aug 3, 2022
3f4065a
[Header] New logo position (#1864)
LucasLacerdaUX Aug 4, 2022
fcb0fc8
update predictive search container width (#1878)
metamoni Aug 4, 2022
87b7f1e
Update 20 translation files (#1891)
translation-platform[bot] Aug 4, 2022
7a05ef0
Fix filter bug to allow filters to be removed (#1890)
sofiamatulis Aug 4, 2022
f62ef25
[Product layout] Add desktop media position (#1720)
Aug 4, 2022
e86f35a
Update 2 translation files (#1896)
translation-platform[bot] Aug 5, 2022
7b9402a
Switch blog header img to eager instead of lazy load (#1894)
siakaramalegos Aug 5, 2022
816b5b4
Update 1 translation file (#1899)
translation-platform[bot] Aug 8, 2022
b947a97
fix(sections/header): remove duplicated classnames (#1853)
KasperAndersson Aug 8, 2022
7198239
change done in pickup availability (#1831)
dexter845 Aug 8, 2022
3f64fa9
Fix spaces in menu IDs by replacing titles with handles (#1846)
n-dawson Aug 8, 2022
9ccd599
Increase left and top edge for zoom-icon element (#1902)
eugenekasimov Aug 9, 2022
f538b0a
fix: drawer - typing in quantity and pressing enter empties cart (#1881)
treboryx Aug 9, 2022
b10202c
hide quick add button when javascript is disabled (#1904)
metamoni Aug 11, 2022
37e4d30
Update PULL_REQUEST_TEMPLATE.md (#1892)
melissaperreault Aug 11, 2022
50cf9d7
Update Lighthouse CI (#1898)
Aug 19, 2022
d3adce4
Update card style default for collage (#1922)
sofiamatulis Aug 22, 2022
28f7d5b
Update 1 translation file (#1924)
translation-platform[bot] Aug 22, 2022
4558947
Update PULL_REQUEST_TEMPLATE.md to include visual change reference (#…
melissaperreault Aug 22, 2022
215f8d6
Fix slider padding and whitespace issue on Safari (#1669)
ludoboludo Aug 23, 2022
1a486f9
Update 1 translation file (#1928)
translation-platform[bot] Aug 24, 2022
32549fb
Add a max width to iframes within the product info container (#1929)
ludoboludo Aug 24, 2022
14c93e2
Fix popup cart notification overlap in the latest Safari version (#1912)
ludoboludo Aug 30, 2022
8565688
Fix video controls on the feat product section (#1940)
ludoboludo Sep 2, 2022
2091738
Update 1 translation file (#1948)
translation-platform[bot] Sep 6, 2022
381a457
Update 1 translation file (#1949)
translation-platform[bot] Sep 6, 2022
00026ae
Update 1 translation file (#1951)
translation-platform[bot] Sep 7, 2022
05bac18
[Product page] Add 2 column layout for desktop and mobile (#1766)
Sep 8, 2022
8d2b34d
Android menu drawer account fix (#1945)
ludoboludo Sep 9, 2022
fc0e628
Update 8 translation files (#1956)
translation-platform[bot] Sep 12, 2022
c1511ae
Use image tag (#1906)
tylerrowsell Sep 12, 2022
592c598
Complementary products (#1938)
ludoboludo Sep 12, 2022
85cd64e
Update translations: buyer (#1963)
translation-platform[bot] Sep 14, 2022
c891534
Fix shadow being cut on featured collection slider, featured blog sli…
sofiamatulis Sep 14, 2022
fbfe88e
Remove Product Subtitle block from Featured Product section (#1964)
KaichenWang Sep 14, 2022
abd203b
[Complementary product] Keep text alignment to the left for horizonta…
ludoboludo Sep 14, 2022
44b0c2d
Update version and release notes (#1966)
kmeleta Sep 15, 2022
0a54646
fix margin-top on middle center header option (#1970)
ludoboludo Sep 15, 2022
d6d97c5
Update 1 translation file (#1967)
translation-platform[bot] Sep 16, 2022
a74e1aa
fix slider controls showing in certain scenarios on mobile (#1973)
ludoboludo Sep 19, 2022
d055968
fix closing element (#1981)
ludoboludo Sep 21, 2022
0c22696
Variant media modal fix (#1985)
kmeleta Sep 23, 2022
1066a84
Ensure complementary block loads card css (#1991)
kmeleta Sep 28, 2022
2dcf808
[Complementary block] update url from the info text to the latest (#1…
ludoboludo Sep 28, 2022
2948b89
Add version bump and release notes (#1997)
ludoboludo Sep 29, 2022
360557c
Enable language/country selector by default (#1988)
slucaskim Sep 30, 2022
92d8eca
Fetch the header (LCP) image at high priority (#1918)
siakaramalegos Sep 30, 2022
7e696e9
[Product page] "Icon with text" block (#1933)
eugenekasimov Oct 3, 2022
6d2a6c9
Add shopify attributes to description block on product page (#2005)
eugenekasimov Oct 4, 2022
6aa8e6c
Add variant picker sold out UI [temporary solution] (#1407)
cfxd Oct 12, 2022
1005c58
Move product media gallery and modal into snippets [Refactor] (#1934)
kmeleta Oct 12, 2022
8ce3734
Update 1 translation file (#2023)
translation-platform[bot] Oct 12, 2022
4616713
Remove setting for variant styling (#2025)
ludoboludo Oct 13, 2022
0c27374
Update 30 translation files (#2026)
translation-platform[bot] Oct 17, 2022
6a9a631
Minor improvements to product media liquid [Refactor] (#2022)
kmeleta Oct 17, 2022
147c21e
Prevent ui changes from variant selection queues (#2030)
kmeleta Oct 18, 2022
3f89aa5
Prevent hidden Variant Picker block from breaking Quick Add (#2049)
LucasLacerdaUX Oct 19, 2022
67fbde2
Fix 'Cannot read properties of null' error in SliderComponent (#2053)
metamoni Oct 21, 2022
acff8d7
remove redundant role from SVGs (#2037)
metamoni Oct 24, 2022
339c84f
Fix z-index issue for mega menu in Safari (#2034)
ludoboludo Oct 24, 2022
0643730
[PDP] Add SKU block (#1987)
eugenekasimov Oct 25, 2022
81f194a
Adjust mobile media selectors for new product-thumbnail markup (#2050)
kmeleta Oct 25, 2022
01ff64b
Add zoom flexibility (#1983)
metamoni Oct 26, 2022
652820f
Prevent media background on deferred-media container (#2068)
kmeleta Oct 26, 2022
57b689e
Add Inventory status block (#1979)
eugenekasimov Oct 26, 2022
287add2
[Product page & feat. product] Fix unavailable variant issue (#2031)
ludoboludo Oct 27, 2022
44107e7
Merge branch 'Shopify:main' into dynamic-selectors
JonoHall Nov 11, 2022
c884b49
Reset to default
JonoHall Nov 11, 2022
6856ffd
Reset files
JonoHall Nov 11, 2022
156d0ba
Reset changes
JonoHall Nov 11, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ And since legacy browsers are often the slowest, we don’t burden them with pol

You can follow these steps to go from setting up a store to creating a pull request for Dawn.

>:information_source: We'll assume you're already set up with Git and GitHub (if you're not familiar with these, [start with these docs](https://docs.github.com/en/github/getting-started-with-github/quickstart/set-up-git)).
>:information_source: We'll assume you're already set up with Git and GitHub (if you're not familiar with these, [start with these docs](https://docs.github.com/github/getting-started-with-github/quickstart/set-up-git)).

1. Set up a [development store](https://shopify.dev/themes/tools/development-stores) so you can test your code changes (assuming you don't already have a store).
2. Install the [Shopify CLI](https://github.com/Shopify/shopify-cli) by following [these steps](https://shopify.dev/themes/tools/cli/installation).
Expand Down Expand Up @@ -156,6 +156,6 @@ When you open a pull request, you must fill out the "Ready for review" template

### Suggested changes

We may ask for changes to be made before a PR can be merged, either using [suggested changes](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) or pull request comments. You can apply suggested changes directly through the UI. You can make any other changes in your fork, then commit them to your branch.
We may ask for changes to be made before a PR can be merged, either using [suggested changes](https://docs.github.com/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) or pull request comments. You can apply suggested changes directly through the UI. You can make any other changes in your fork, then commit them to your branch.

As you update your PR and apply changes, mark each conversation as [resolved](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
As you update your PR and apply changes, mark each conversation as [resolved](https://docs.github.com/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
34 changes: 24 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,41 @@
**PR Summary:**
### PR Summary:

_Please include a short description (using non-technical terms, 1-2 sentences) about the changes you are introducing, what problem is being fixed and/or describe the benefit to merchants. This content will be used in our release notes for Dawn on [themes.shopify.com](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes)._
<!-- Please include a short description (using non-technical terms, 1-2 sentences) about the changes you are introducing, what problem is being fixed and/or describe the benefit to merchants. This content will be used in our release notes for Dawn on [themes.shopify.com](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes). -->


**Why are these changes introduced?**
### Why are these changes introduced?

Fixes #0.

**What approach did you take?**
### What approach did you take?

**Other considerations**
### Other considerations

**Testing steps/scenarios**
- [ ] _List all the testing tasks that applies to your fix and help peers to review your work._
### Decision log

**Demo links**
_Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on._
| # | Decision | Alternatives | Rationale | Downsides |
|---|---|---|---|---|
| 1 | | | | |


### Visual impact on existing themes
<!-- How will this visually affect merchants who upgrade to a new theme version with this change? -->


### Testing steps/scenarios
<!-- List all the testing tasks that applies to your fix to help peers review your work. -->
- [ ] Step 1

### Demo links
<!-- Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on. -->

- [Store](url)
- [Editor](url)

**Checklist**
### Checklist
- [ ] Added PR summary for [release notes](https://themes.shopify.com/themes/dawn/styles/default#ReleaseNotes)
- [ ] Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
- [ ] Created a ticket for the [help.shopify.com](https://help.shopify.com) documentation team about updates to theme settings. (Internal-only task)
- [ ] Followed [theme code principles](https://github.com/Shopify/dawn/blob/main/.github/CONTRIBUTING.md#theme-code-principles)
- [ ] Linted with [Theme Check](https://github.com/Shopify/theme-check)
- [ ] Tested on [mobile](https://shopify.dev/themes/store/requirements#mobile-browser-requirements)
Expand Down
2 changes: 0 additions & 2 deletions .github/probots.yml

This file was deleted.

15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,20 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Lighthouse
uses: shopify/lighthouse-ci-action@1.0
uses: shopify/lighthouse-ci-action@v1
with:
app_id: ${{ secrets.SHOP_APP_ID }}
app_password: ${{ secrets.SHOP_APP_PASSWORD }}
store: ${{ secrets.SHOP_STORE }}
password: ${{ secrets.SHOP_PASSWORD }}
lhci_github_token: ${{ secrets.LHCI_GITHUB_TOKEN }}
store: ${{ secrets.SHOP_STORE_OS2 }}
password: ${{ secrets.SHOP_PASSWORD_OS2 }}
access_token: ${{ secrets.SHOP_ACCESS_TOKEN }}
product_handle: puppy
collection_handle: all
lhci_github_app_token: ${{ secrets.LHCI_GITHUB_TOKEN }}
theme-check:
name: Theme Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Theme Check
uses: shopify/theme-check-action@v1
with:
token: ${{ github.token }}
22 changes: 22 additions & 0 deletions .github/workflows/cla.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Contributor License Agreement (CLA)

on:
pull_request_target:
types: [opened, synchronize, reopened]
issue_comment:
types: [created]

jobs:
cla:
runs-on: ubuntu-latest
if: |
(github.event.issue.pull_request
&& !github.event.issue.pull_request.merged_at
&& contains(github.event.comment.body, 'signed')
)
|| (github.event.pull_request && !github.event.pull_request.merged)
steps:
- uses: Shopify/shopify-cla-action@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
cla-token: ${{ secrets.CLA_TOKEN }}
2 changes: 2 additions & 0 deletions .theme-check.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
MatchingTranslations:
enabled: false
TemplateLength:
enabled: false
Loading