Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN-7378] feat(CV): Photo preview is now profile picture #346

Merged
merged 8 commits into from
Sep 19, 2024
Merged

[EN-7378] feat(CV): Photo preview is now profile picture #346

merged 8 commits into from
Sep 19, 2024

Conversation

guillobits
Copy link
Contributor

No description provided.

@guillobits guillobits requested a review from DDZBX September 18, 2024 15:49
@guillobits guillobits self-assigned this Sep 18, 2024
@guillobits guillobits temporarily deployed to entourage-job-front September 18, 2024 15:49 — with GitHub Actions Inactive
@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024 •
edited
Loading

Default Project    Run #1208

Run Properties:  status check passed Passed #1208  •  git commit 05029fa1a5 ℹ️: Merge 7c9caf000a308641afd6a447da5f19918a3548fd into 005b5883c93d19e34113a8d22890...
Project Default Project
Branch Review feature/EN-7378-FO-New-design-photo-miniature-de-partage
Run status status check passed Passed #1208
Run duration 04m 46s
Commit git commit 05029fa1a5 ℹ️: Merge 7c9caf000a308641afd6a447da5f19918a3548fd into 005b5883c93d19e34113a8d22890...
Committer CAUCHOIS Guillaume
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 30
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

DDZBX
DDZBX approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@DDZBX DDZBX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Effectivement, ca simplifie pas mal le code, meme remarque pour les GA TAGS

@guillobits guillobits temporarily deployed to entourage-job-front September 19, 2024 13:54 — with GitHub Actions Inactive
@guillobits guillobits merged commit f0ff545 into develop Sep 19, 2024
3 checks passed
@guillobits guillobits deleted the feature/EN-7378-FO-New-design-photo-miniature-de-partage branch September 19, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDZBX DDZBX DDZBX approved these changes

Assignees

@guillobits guillobits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillobits @DDZBX