chore(icons): remove all uikit icons #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
92151c2 to
40b69ab
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
40b69ab to
291ce47
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
291ce47 to
0f9b607
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
0f9b607 to
2e1aa33
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
2e1aa33 to
b91d116
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
b91d116 to
594f6a9
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
594f6a9 to
694e862
Compare
emile-bex
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
emile-bex
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
fdc968b to
8d556c4
Compare
emile-bex
had a problem deploying
to
entourage-job-front
GitHub Actions
Failure
emile-bex
force-pushed
the
feature/EN-6375_Replace_Icons
branch
from
8d556c4 to
9389e14
Compare
emile-bex
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
| @@ -1,7 +1,8 @@ | |||
| import React, { useEffect, useState } from 'react'; | |||
| import Resizer from 'react-image-file-resizer'; | |||
| import UIkit from 'uikit'; | |||
| import { Icon } from 'src/components/utils'; | |||
| import PencilIcon from 'assets/icons/pencil.svg'; | |||
| import {} from 'src/components/utils'; | |||
| @@ -1,7 +1,7 @@ | |||
| export interface HeaderConnectedItemProps { | |||
| href: string; | |||
| badge?: string; | |||
| icon?: string; | |||
| icon?: JSX.Element; | |||
There was a problem hiding this comment.
Alors ici on sait qu'on veut passer des icônes SVG du style <UserIcon />, du coup on sait que ce sera forcément un JSX.Element. React.ReactNode englobe aussi les string et les autres types de node, etc...
| @@ -8,7 +8,7 @@ interface ButtonPostProps { | |||
| color?: string; | |||
| action?: (event?: FormEvent) => Promise<void>; | |||
| style?: '' | UIKIT_BUTTON_STYLES_SPEC; | |||
| icon?: string; | |||
| icon?: JSX.Element; | |||
There was a problem hiding this comment.
Alors ici on sait qu'on veut passer des icônes SVG du style , du coup on sait que ce sera forcément un JSX.Element. React.ReactNode englobe aussi les string et les autres types de node, etc...
| import { StyledButtonIcon } from './ButtonIcon.styles'; | ||
|
|
||
| interface ButtonIconProps { | ||
| icon: JSX.Element; |
There was a problem hiding this comment.
Alors ici on sait qu'on veut passer des icônes SVG du style , du coup on sait que ce sera forcément un JSX.Element. React.ReactNode englobe aussi les string et les autres types de node, etc...
emile-bex
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
PaulEntourage
approved these changes
Dec 4, 2023
…#164) * chore(icons): remove all uikit icons * started public offer form * [EN-6475] feat(offer form): separate public and private offer form * [EN-6475] tests(offer form): update tests * [EN-6475] fix(offer form): fix modal scroll to top * [EN-6475] feat(offer form): change wording * [EN-6475] chore(icons): manage auto margin if icons in buttons
emile-bex
temporarily deployed
to
entourage-job-front
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.