Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: add input object document #25

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Apr 24, 2023

Add input object document to the crate.

@simleo
Copy link
Collaborator Author

simleo commented Apr 24, 2023

For now it's added as-is, without remapping location entries to the files in the crate.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (0c331a0) 95.64% compared to head (fd46a97) 95.68%.

❗ Current head fd46a97 differs from pull request most recent head b181ff8. Consider uploading reports for the commit b181ff8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   95.64%   95.68%   +0.03%     
==========================================
  Files          11       11              
  Lines        1517     1528      +11     
==========================================
+ Hits         1451     1462      +11     
  Misses         66       66              
Impacted Files Coverage Δ
src/runcrate/convert.py 98.09% <100.00%> (+0.02%) ⬆️
tests/test_cwlprov_crate_builder.py 99.84% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simleo
Copy link
Collaborator Author

simleo commented Apr 24, 2023

For now it's added as-is, without remapping location entries to the files in the crate.

Done in b181ff8

@simleo simleo marked this pull request as ready for review April 24, 2023 14:10
@simleo simleo merged commit a728698 into ResearchObject:main Apr 24, 2023
@simleo simleo deleted the add_params_file branch April 24, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant