Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set param names to those expected by CWL #22

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Mar 23, 2023

In the convert module, Set the name property of FormalParameter instances to the plain name (e.g., no main/ prefix) expected by the CWL workflow in the parameter settings, to support reproducibility. PropertyValue names are also set accordingly.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (7033cd2) 99.00% compared to head (ccfec4e) 99.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   99.00%   99.02%   +0.02%     
==========================================
  Files          10       10              
  Lines        1301     1328      +27     
==========================================
+ Hits         1288     1315      +27     
  Misses         13       13              
Impacted Files Coverage Δ
src/runcrate/convert.py 98.06% <100.00%> (ø)
tests/test_cwlprov_crate_builder.py 99.84% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant