Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.is_url
currently returnsFalse
if the netloc field is empty, causing two main problems:mailto:
entity IDs as absolute URLs, which results in a leading hash mark being added to the IDfile:///tmp/foo.txt
, which are treated as relative pathsIn the latter case, the following call:
Results in an output entry of:
Though no file is added to the crate dir (see #75) unless the current working directory has a
file:/tmp/foo.txt
file in it (file:
is a legal directory path in some OSs, e.g. Linux).With this PR, the generated file entry is:
Note that it's still possible to add a file whose relative (to the CWD) path is
file:/tmp/foo.txt
(or similar) by passing its absolute path toadd_file
.